Fix unlimited advert blob growth on ESP32 - #1495
Merged
Merged
Conversation
oltaco
marked this pull request as draft
January 27, 2026 07:47
oltaco
force-pushed
the
esp32-advblob-removal
branch
from
January 27, 2026 07:53
1016c39 to
6287305
Compare
oltaco
marked this pull request as ready for review
January 27, 2026 07:54
Member
Author
|
Thankfully @liamcottle noticed that putBlobByKey() wasn't being called in the update contact path. Fixed now. |
oltaco
force-pushed
the
esp32-advblob-removal
branch
from
January 27, 2026 08:06
6287305 to
e93e12e
Compare
Member
Author
|
Now with added helper 👍 |
liamcottle
approved these changes
Jan 27, 2026
Member
|
Looks good thanks! Removed some duped code, and advert blobs shouldn't fill the filesystem anymore :) |
ripplebiz
reviewed
Jan 31, 2026
| // storage concepts, for sub-classes to override/implement | ||
| virtual int getBlobByKey(const uint8_t key[], int key_len, uint8_t dest_buf[]) { return 0; } // not implemented | ||
| virtual bool putBlobByKey(const uint8_t key[], int key_len, const uint8_t src_buf[], int len) { return false; } | ||
| virtual bool deleteBlobByKey(const uint8_t key[], int key_len) { return true; } // returns true even if blob did not exist |
Member
There was a problem hiding this comment.
I'm not sure this is ever called?
Member
Author
There was a problem hiding this comment.
Good catch, I've removed that and force pushed 👍
oltaco
force-pushed
the
esp32-advblob-removal
branch
from
January 31, 2026 13:02
d90a66e to
8d5eaf5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects ESP32 (and RP2040?) devices never removing old advert blobs, leading to the filesystem getting filled.
Changes:
Tested on Heltec V3 and confirmed that advert blobs are now removed on overwrite and when removing contacts via the app.
Tested on RAK4631 and confirmed no change in behaviour.