Fix PA on RAK3401 when GPS missing - #3275
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug I introduced in #3268 where the PA on RAK3401 would not be powered if a GPS module was not present.
The existing logic to probe for GPS modules at boot turns on a few IO pins, and then turns them off.
This included the 3V3 rail on
WB_IO2. We must not turn offWB_IO2on RAK3401.I've tested PA output power with GPS present and GPS missing.
Turning GPS on and off will no longer toggle these IO pins.
Ideally we wouldn't add board specific defines like this into the
EnvironmentSensorManager, but we already haveRAK_WISBLOCK_GPSanyway...