You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note that the branch protection rule is a pattern, which I expect is very rarely used, but you should probably fail or warn if the pattern contains a *.
I haven't used your CLI yet, but I think you have the feature to keep the previous branch around. So maybe it should not be an update of the pattern, but a copy of the settings?
Activity
foolip commentedon Jun 15, 2020
Note that the branch protection rule is a pattern, which I expect is very rarely used, but you should probably fail or warn if the pattern contains a
*.gr2m commentedon Jun 18, 2020
Here is what I do in
octokit-plugin-rename-branch:https://github.com/gr2m/octokit-plugin-rename-branch/blob/5d3c37439515db9f49f049e28510dc596982cb02/src/rename-branch.ts#L56-L90
The code looks for exact matches and updates it. It does not copy it, as that's out of scope for
octokit-plugin-rename-branchUpdate branch protections
Update branch protections
gr2m commentedon Jun 18, 2020
Thanks for the shout out :)
I haven't used your CLI yet, but I think you have the feature to keep the previous branch around. So maybe it should not be an update of the pattern, but a copy of the settings?
Merge pull request #4 from 6RiverSystems/fix/help-text