docs: add sample creation quick guide - #972
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sheri Gilley (sdgilley)
temporarily deployed
to
L4-validation
September 10, 2026 15:48 — with
GitHub Actions
Inactive
Sheri Gilley (sdgilley)
marked this pull request as draft
September 11, 2026 17:46
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sheri Gilley (sdgilley)
deployed
to
L4-validation
September 11, 2026 18:44 — with
GitHub Actions
Active
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sheri Gilley (sdgilley)
deployed
to
L4-validation
September 11, 2026 19:16 — with
GitHub Actions
Active
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sheri Gilley (sdgilley)
deployed
to
L4-validation
September 11, 2026 19:19 — with
GitHub Actions
Active
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…instructions # Conflicts: # .github/scripts/validate-sample.README.md
Sheri Gilley (sdgilley)
deployed
to
L4-validation
September 14, 2026 17:59 — with
GitHub Actions
Active
Sheri Gilley (sdgilley)
marked this pull request as ready for review
September 14, 2026 18:20
Sheri Gilley (sdgilley)
deployed
to
L4-validation
September 14, 2026 18:21 — with
GitHub Actions
Active
Copilot started reviewing on behalf of
Sheri Gilley (sdgilley)
September 15, 2026 23:24
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The quick guide contains unresolved inaccuracies about supported languages, validation scope, cadence, and substitutions.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds a contributor quick guide for creating metadata-bearing samples and understanding validation modes.
Changes:
- Adds
CREATE_SAMPLE.mdwith metadata examples and local validation commands. - Links the guide from repository and contribution documentation.
- Documents validation environment variables, contracts, and cadence behavior.
File summaries
| File | Description |
|---|---|
README.md |
Links to the quick guide. |
CREATE_SAMPLE.md |
Adds sample creation and validation guidance. |
CONTRIBUTING.md |
Directs contributors to the guide. |
.github/validation-pilot.README.md |
Documents cadence variables and references. |
.github/scripts/validate-sample.README.md |
Updates validation contract documentation. |
Review details
Suppressed comments (5)
CREATE_SAMPLE.md:53
- The build-readiness step is not unconditional: Go is supported by PR/local validation but is excluded from cadence discovery, and Rust samples are explicitly skipped. Since this section describes the daily cadence as well,
Always runsis inaccurate for those samples.
- **Build Readiness:** Always runs build/compilation checks on PR touches and daily cadence.
CREATE_SAMPLE.md:26
- The validator treats any declared
build,validate, ortestcommand as authoritative and does not fill omitted commands from the language default (run_sample_yamlreturns success after the declared commands). This wording can lead a contributor who declares onlybuildto assume the default compile step still runs.
# Optional: Custom build & compile overrides (language defaults used if omitted)
CREATE_SAMPLE.md:109
- The build-readiness invocation shown immediately below does not execute or honor
live_service_validation; that block is used only by the separate--mode live-serviceinvocation. As written, this suggests a normal--languagerun will run the live-service command whenever the block is present, contrary to the validator's separate-mode contract.
works whether or not the sample has a `sample.yaml` — without one, the script
falls back to the language's default build/compile check; with one, it honors any
declared `build`/`validate`/`test` commands or `live_service_validation` block.
CREATE_SAMPLE.md:64
- The validator writes substitutions into the target file in place and does not restore it after the command. Because this guide also provides a local live-service invocation, saying it patches the workflow checkout hides that local runs can leave the endpoint or deployment value in the contributor's working tree; warn users to run on a disposable copy or restore the files afterward.
runtime. Declare a `substitutions` list under `live_service_validation` to have the
validator patch the placeholder in the workflow checkout, using an environment
variable, before running the command:
CREATE_SAMPLE.md:115
- The local command uses
<language>while the guide listsjavascript, butvalidate-sample.shrejects--language javascript; only workflow callers map JavaScript paths to thetypescriptvalidator. Add that mapping here so a JavaScript contributor does not copy the listed language into a command that exits with an unsupported-language error.
bash .github/scripts/validate-sample.sh \
--language <language> \
--sample-dir samples/<language>/<sample-name>
- Files reviewed: 5/5 changed files
- Comments generated: 4
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Clarified instructions for including `sample.yaml` and running validations. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sheri Gilley (sdgilley)
deployed
to
L4-validation
September 16, 2026 00:37 — with
GitHub Actions
Active
…_validation scope in CREATE_SAMPLE.md Co-authored-by: sdgilley <3650506+sdgilley@users.noreply.github.com>
Clarified sample requirements and language support details. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sheri Gilley (sdgilley)
deployed
to
L4-validation
September 17, 2026 15:15 — with
GitHub Actions
Active
Sheri Gilley (sdgilley)
deleted the
sdgilley-create-file-instructions
branch
September 17, 2026 15:39
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a concise entry point for contributors who need to create a metadata-bearing sample and understand how it is validated.
The guide distinguishes build-readiness-only samples from samples that opt into live-service validation, provides the minimum
sample.yamlshape and local validation commands, and links to the detailed validation contracts.