Skip Azure VM resource detection on App Service - #3209
Andreas Lillje (alillje) wants to merge 4 commits into
Conversation
@microsoft-github-policy-service agree |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
| { | ||
| try | ||
| { | ||
| if (Environment.GetEnvironmentVariable(ResourceAttributeConstants.AppServiceSiteNameEnvVar) != null) |
There was a problem hiding this comment.
Since this file is vendored from open-telemetry/opentelemetry-dotnet-contrib (link to this file), it's better to make the corresponding change in the upstream repository and sync it here.
Otherwise it could cause the behavior to diverge from the source project and be overwritten during a future vendor refresh. Ideally, the upstream implementation should become the source of truth, followed by a vendored update here.
There was a problem hiding this comment.
Thanks for the guidance. I’ve now submitted the change upstream: open-telemetry/opentelemetry-dotnet-contrib#5167. I’ll keep this PR as a draft while the upstream change is reviewed.
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
Fixes #3179.
Changes
WEBSITE_SITE_NAMEenvironment variable identifies the application as running on Azure App Service.Checklist