Skip to content

Update Sampling Percentage to Accept 0 as Valid#1337

Merged
JacksonWeber merged 7 commits into
microsoft:mainfrom
JacksonWeber:jacksonweber/allow-zero-sampling
Jun 7, 2024
Merged

Update Sampling Percentage to Accept 0 as Valid#1337
JacksonWeber merged 7 commits into
microsoft:mainfrom
JacksonWeber:jacksonweber/allow-zero-sampling

Conversation

@JacksonWeber
Copy link
Copy Markdown
Contributor

@JacksonWeber JacksonWeber commented May 30, 2024

  • Previously setting the sampling percentage as 0 would actually set sampling to 1 as 0 is falsy and would revert to the default value of the sampling percentage.

Resolves #1336

@JacksonWeber JacksonWeber requested a review from hectorhdzg May 30, 2024 18:02
Copy link
Copy Markdown
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JacksonWeber JacksonWeber merged commit c98e546 into microsoft:main Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to Disable Logging by Setting samplingRate to Zero

2 participants