This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Bumped Electron from 4.1.1 to 11.0.1 - #2226
Merged
Merged
Conversation
Contributor
Author
|
Thanks for the review Corina (@corinagum) . I'm going to fix the linting and the tests as well and re-push so I might ping you again for a second review :) |
Corina (corinagum)
approved these changes
Feb 3, 2021
Corina (corinagum)
left a comment
Corina (corinagum)
left a comment
Contributor
There was a problem hiding this comment.
LGTM - one non-blocking question
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
electronto 11.0.1 🚀🚀🚀typescriptto 4.1.3keytarto 7.3.0electron-rebuildto 2.3.4eslintto 7.19.0Fixed some breaking API changes as a result of bumping Electron
Here's a working Windows CI build: https://fuselabs.visualstudio.com/BotFramework-Emulator/_build/results?buildId=207729&view=artifacts&pathAsName=false&type=publishedArtifacts
The other pipelines will be fixed to accommodate these changes