Remove NGrok. Configure Tunnel URL - #2461
Conversation
* update fileMenu * add tunnelUrl * get serviceUrl from settings * showPort * rm ngrok settings * showPort * rm ngrokdebugger * rm ngroddebug from editor * rm ngrokService * rm nGrokTab * rm ngrok sagas, actions, styles * rm ngrok settings * upd version, and deps
…sEditor.tsx Co-authored-by: Eugene <EOlonov@gmail.com>
Co-authored-by: Eugene <EOlonov@gmail.com>
|
Looks good. I think the only piece which is missing right now is UI changes for ngrok tab. See As we are probably not able to track status of the tunnel, we may remove the tab. |
yep, removed in last commit |
Cecilia Avila (ceciliaavila)
left a comment
Cecilia Avila (ceciliaavila)
left a comment
There was a problem hiding this comment.
I can see several references to ngrok in the specs. Also, a few dedicated ngrok tests. Should we keep these?
e.g.:
logEntry.spec.tsx
util.spec.ts
I was not looking at test runs, I can remove all references to ngrok in tests as well. |
|
Cecilia Avila (@ceciliaavila) spec.ts files updated to remove any reference to ngrok in 45635ca |
3 participants
Removes NGrok dependencies.
To test remote bots, the user has to configure a tunnel - any tunnel software will work - pointing to the emulator service. The tunnel needs to be configured to target to the actual port used by the emulator service.
The port is shown in the settings page and is also available to copy to the clipboard via File Menu.
I've tested with Ngrok, and Microsoft.devTunnel
Version bumped to
4.15.1availabe to download for testing from ADO: BotFramework-Emulator-4.15.1-windows-setup.exe