Validate settings if BindParameters is not called - #429
Closed
Zhiyuan Liang (zhiyuanliang-ms) wants to merge 2 commits into
Closed
Zhiyuan Liang (zhiyuanliang-ms) wants to merge 2 commits into
Zhiyuan Liang (zhiyuanliang-ms) wants to merge 2 commits into
Conversation
Zhiyuan Liang (zhiyuanliang-ms)
requested a review
from Ross Grambo (rossgrambo)
April 16, 2024 03:11
Zhiyuan Liang (zhiyuanliang-ms)
deleted the
zhiyuanliang/validate-settings-if-no-prebound
branch
April 16, 2024 03:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this PR?
Fix the bug introduced by this PR: #387
In #387, the validation of settings was moved to BindParameters to avoid redundant validation. However, if BindParameters is not called, the validation will be skipped.