This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Remove support for Java 7 on Mac OS X 10.11 and up#32
Merged
Conversation
added 2 commits
March 16, 2016 21:34
Mac OS X is now dependent on its version for the minimum Java version.
olivierdagenais
added a commit
that referenced
this pull request
Mar 17, 2016
Remove support for Java 7 on Mac OS X 10.11 and up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow-on to microsoft/oauth2-useragent#19, update documentation and Homebrew formula to identify Java 8 when running on Mac OS X 10.11 (El Capitan) or greater.
Manual testing
Install Homebrew.
Temporarily inject the changes to
Library/Formula/git-credential-manager.rbin the Git repo that's cloned as part of installing Homebrew.Temporarily uninstall Java.
Attempt to install the
git-credential-managerformula:Install JDK 7u80.
Install the
git-credential-managervia Homebrew:Install the GCM in Git:
Confirm the GCM was configured in
~/.gitconfig.Clone a Git repo hosted in VSTS, clearing any previously-saved credentials if necessary to force the OAuth 2.0 auth flow with the web browser pop-up.
Install Homebrew.
Temporarily inject the changes to
Library/Formula/git-credential-manager.rbin the Git repo that's cloned as part of installing Homebrew.Temporarily uninstall Java.
Attempt to install the
git-credential-managerformula:Install JDK 8u73.
Install the
git-credential-managervia Homebrew:Install the GCM in Git:
Confirm the GCM was configured in
~/.gitconfig.Clone a Git repo hosted in VSTS, clearing any previously-saved credentials if necessary to force the OAuth 2.0 auth flow with the web browser pop-up.
Mission accomplished!