This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Extend Device Flow to support Azure Active Directory#39
Merged
Conversation
added 6 commits
April 15, 2016 11:36
This is to accomodate Azure Active Directory returning string values for "expires_in" and "interval".
Azure Active Directory can return what appears to be an array of integers and this would cause the parser to throw an error as '[' was not a valid value character. This is worked around by considering square brackets as a fancy means of quoting and as long as the array does not contain a nested array or strings containing square brackets, we should be able to parse this JSON enough to collect the "conformant" name/values.
Azure Active Directory authorization requests need to include the "resource" parameter. The test makes sure we can build a TokenPair (or a subclass thereof) based on an adapted sample response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few differences from the OAuth 2.0 Device Flow specification draft 01 which this pull request bridges.