This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Wire up the new Device Flow feature#40
Merged
Merged
Conversation
added 8 commits
April 15, 2016 13:13
Now that we have a more reliable authentication method to fallback onto, we won't need to re-throw as much on failure.
Removed an extra set on the outside, fixed the last block and re-indented for consistency.
117fe0c to
85f67cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OAuth 2.0 Device Flow is now wired up and will be attempted as a last resort.
Manual testing
Add a Git remote to a clone of this repo pointing to a VSTS account that uses Microsoft Accounts (MSA). Let's call the remote
msarepo.Run
git push msarepo.When the JavaFX browser opens, immediately close the window. This used to completely abort the GCM4ML; now we get something like this:
Follow the instructions to authenticate.
The push succeeds.
Add a Git remote to a clone of this repo pointing to a VSTS account that uses Azure Active Directory (AAD). Let's call the remote
aadrepo.Run
git push aadrepo.When the JavaFX browser opens, immediately close the window. This used to completely abort the GCM4ML; now we get something like this:
Follow the instructions to authenticate.
The push succeeds.
Mission accomplished!