This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Minor unit test improvements#44
Merged
Merged
Conversation
added 3 commits
May 20, 2016 15:11
When running with the "debug" system property set to "true", some tests would fail due to Token wanting a non-null value in its constructor.
AzureAuthority's constructor wants a non-null UserAgent implementation, hence the NullUserAgent.
It looks like a background thread was trying to log data from a request that had its refcount hit 0. Calling retain() will increase the refcount.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commits for issues fixed.