This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Reduce JavaFX failure output#45
Merged
Merged
Conversation
added 2 commits
June 3, 2016 12:17
This makes use of the recently-added ProviderScanner to more gracefully check for availability and then report unavailablity (if applicable) in a much less alarming fashion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual Testing
These steps were performed on my Windows 10 workstation:
Temporarily disable the insecure store file to force authentication. I did that by appending
.oldto%LOCALAPPDATA%/git-credential-manager/insecureStore.xml.Create a file called input.txt containing the following:
Launch the GCM4ML in
getmode, with stdin coming frominput.txtand using a JRE that doesn't support JavaFX, such as Java 6. This is what my command-line looked like:Before the changes from this pull request, we would have gotten the following debug output:
...and now we get the following debug output:
Re-enable the insecure store file.
Mission accomplished!