This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Make hardcoded credential-osxkeychain workaround opt-out instead of opt-in#47
Merged
Merged
Conversation
added 2 commits
June 30, 2016 22:38
The "Apple Git" workaround can still be disabled by configuring it to FALSE.
It turns out the "Git OSX Installer" brings the same hardcoded osxkeychain credential helper and thus it is no longer sufficient to try to detect based on the Git version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also expand to any version of Git that makes
git-credential-osxkeychainavailable, not just "Apple Git". This covers the Git OSX Installer which has a more "traditional" version string, yet behaves the same with respect to hardcoding the osxkeychain credential helper first.Manual testing
For each of the following distributions of Git:
...performed a
git fetchagainst a Visual Studio Team Services Git repository and kept a close eye on the Keychain application. For Apple and OSX Installer, an entry would briefly appear in the Keychain before being deleted by the GCM4ML. In the Homebrew case, no entry appeared. In all cases, the fetch succeeded.Mission accomplished!