This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Add support for GNOME Keyring#49
Merged
Merged
Conversation
added 15 commits
July 6, 2016 08:46
This is in preparation for consuming a library that depends on slf4j; calls through slf4j should end up through the Trace, as demonstrated by the TraceLoggerTest.
1 - auth-secure-storage depends on slf4j-api:1.7.19,
so the latter was removed.
2 - auth-secure-storage depends on auth-common,
which imported a lot of code from this project
so it can now be deleted from here.
3 - auth-secure-storage depends on third-party OSS,
so ThirdPartyNotices.txt and EULA.txt were added.
Some related content was added to the ReadMe.md,
plus some filtering to remove the MIT License from
the binary release artifacts.
This will cause the GCM4ML to use auth-secure-storage's components, with a migration from insecureStore.xml if that file is found.
The InsecureStore should now only be used for migrating.
1 - GNOME Keyring now supported on GNU/Linux. 2 - Automatic import from insecureStore.xml on first run.
|
Looks good, and thanks for the excellent doc updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The bulk of the work to support the GNOME Keyring on Linux was to adopt the
auth-secure-storagemodule of the Visual Studio Team Services Authentication Library for Java, removing a lot of the code that was effectively moved to the library's modules.Manual testing
git fetchfrom it.~/git-credential-manager/insecureStore.xml; it was imported in the GNOME Keyring and then the token was used to successfully fetch.git fetch.Mission accomplished!