This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Support Java 9+#77
Merged
Merged
Conversation
There was a change made to the oauth2-useragent dependency to fix an issue with parsing newer versions of Java. This change updates to that newer version to include the fix. Additionally, it appears javax.xml.bind is no longer included with Java 9. This has been included as a maven dependency to resolve class def errors once the oauth2-useragent error was resolved.
Need to use an older version of maven if it will use jdk6. Relevant issue on Github for Travis: travis-ci/travis-ci#8452
Contributor
Author
|
The extra commits were an attempt at getting jdk6 working on Travis, definitely causes some issues. Using jdk7 builds successfully. I can close and open two pull requests if that is preferred. |
davidstaheli
approved these changes
Apr 3, 2018
Contributor
Author
|
@davidstaheli is it possible to get a release with this PR merged? |
|
Bumping this again since we'd like this merged also. |
|
We'd still like this merged. @davidstaheli is this possible? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a change made to the oauth2-useragent dependency to fix an
issue with parsing newer versions of Java. This change updates to that
newer version to include the fix.
Additionally, it appears javax.xml.bind is no longer included with Java
9. This has been included as a maven dependency to resolve class def
errors once the oauth2-useragent error was resolved.