Repository navigation
Require exact draft scans and bound publication-history lookups - #494
Merged
Merged
Conversation
Stage the exact candidate in detector input and require successful execution, a successful verdict, and a matching immutable scan binding before sealing. Query publication intents by draft artifact name with a two-result bound while preserving retry protection. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
5 tasks done
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The compiled detection guard excludes file-only candidates with no native outputs or patch, preventing download and scanning and causing the seal condition to skip the draft.
1 open issue
What changed in this PR
This follow-up to #493 strengthens the discussion-drafting pilot’s scan requirements and bounds publication-history lookups without changing owner approval boundaries.
Changes:
- Stages exact candidate bytes for detection and requires a successful scan, verdict, and matching run-specific binding before sealing.
- Replaces workflow-history enumeration with draft-keyed artifact lookups capped at two matches per request.
- Updates automation documentation and regression coverage for scan provenance, tampering, and publication retries.
| File | Description |
|---|---|
tools/tests/discussion-workflows.test.mjs |
Checks detector wiring, scan artifacts, and sealing conditions. |
tools/tests/discussion-draft.test.mjs |
Covers candidate integrity, scan provenance, retries, and bounded history requests. |
tools/discussion-draft.mjs |
Adds scan-binding validation and exact-name publication-intent lookups. |
AUTOMATION.md |
Documents scan requirements and bounded publication-history checks. |
.github/workflows/discussion-draft.md |
Adds candidate staging, scan-binding uploads, and stricter sealing gates. |
.github/workflows/discussion-draft.lock.yml |
Regenerates the executable workflow with the detection and sealing changes. |
Review effort: Balanced
Tal Zaccai (TalZaccai)
approved these changes
Oct 30, 2026
Seed a trusted read-only native no-op before model execution so the pinned detector guard cannot skip a candidate with no model-emitted safe outputs or patch. Reserve the signal slot without removing the existing two model no-ops, and exercise the generated Bash guard in a regression test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
SAML-blocked access to the pinned gh-aw runtime leaves it unverified whether staged input survives setup and reaches the live scan, a boundary mocked tests cannot establish and human verification must confirm.
No open issues 🎉
1 resolved since last review
Review effort: Balanced
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Follow-up to #493, which was merged while these fixes were being prepared. Addresses the two remaining Copilot review-summary concerns without changing the pilot's approval boundaries.
Changes
Verification
npm testfromtools). Includes mocked workflow-script execution for Issues and Discussions, file-only candidates, scan failures/provenance, byte-level tampering, retry protection, and bounded request counts..gitattributesare unchanged.No live drafting run or bot publication was performed. Human review and the documented live-verification checklist remain required.
Review references: candidate scanning, publication-history cost.