Repository navigation
Fix regression for optional JSDoc types which throws TS2463 in typescript@next #50286
Description
Bug Report
🔎 Search Terms
optional jsdoc regression
🕗 Version & Regression Information
This started occurring in nightly after #50094 was merged to fix #49869 and still happens (see these cron job type checks in pony-cause which retests against nightly three times a week).
This does not happen in 4.8 beta
- This changed between versions 4.8-beta and nightly
⏯ Playground Link
Since the Playground is for TS code, not JS code, here's a link to a piece of code: https://github.com/voxpelli/pony-cause/blob/4009048a41d772cb29673f1c45cc55e9717e523f/lib/error-with-cause.js#L5-L9
And more in this thread: voxpelli/pony-cause#45
💻 Code
/**
* @param {{ cause?: string }} [options]
*/
function foo ({ cause } = {}) { 🙁 Actual behavior
Explicitly specifying the options as optional ([options] ) causes this error as it is already implicitly marked as optional by having been set a default value ({ cause } = {}):
error TS2463: A binding pattern parameter cannot be optional in an implementation signature.
🙂 Expected behavior
One of:
- Preferably that TypeScript keep accepting arguments that's been explicitly marked as optional, even if that is redundant
- At least change the error message to something that makes more sense in a JSDoc context than "
A binding pattern parameter cannot be optional in an implementation signature."
See more in this thread: voxpelli/pony-cause#45 and in #50094 (comment), where Nathan Shively-Sanders (@sandersn) said that he is in favor the current new behavior.
Activity
voxpelli commentedon Aug 26, 2022
Seems like this is actually affecting TS 4.8.2
Fix JSDoc type regression in TS 4.8
Update dev dependencies.
Update dev dependencies.
Downgrade to TypeScript 4.7 temporarily due microsoft/TypeScript#50286
🧹 chore: keep `typescript` at 4.7 until microsoft/TypeScript#50286
Fix type error
chore(package): update dependencies
mohd-akram commentedon Sep 13, 2022
Any update on this?
12 remaining items
fix(marshal): Work around TypeScript issue
chore(types): work around microsoft/TypeScript#50286
fix(marshal): Work around TypeScript issue
fix(marshal): Work around TypeScript issue
fix(marshal): Work around TypeScript issue
Update dev dependencies.
Remove a no longer necessary workaround for a TypeScript bug.
Update dev dependencies.
Update dev dependencies.