Add undefined to Symbol.declarations' type - #42975
Merged
Nathan Shively-Sanders (sandersn) merged 4 commits intoMar 1, 2021
Merged
Add undefined to Symbol.declarations' type#42975Nathan Shively-Sanders (sandersn) merged 4 commits into
Nathan Shively-Sanders (sandersn) merged 4 commits into
Conversation
Symbol.declarations now has type `Declaration[] | undefined`. I made a mistake somewhere in the checker related to JS checking, so there are quite a few test failures right now.
TypeScript Bot (typescript-bot)
added
the
For Uncommitted Bug
Nathan Shively-Sanders (sandersn)
requested review from
Andrew Branch (andrewbranch) and
Eli Barzilay (elibarzilay)
February 26, 2021 01:16
Contributor
|
While you are at it, could you fix the rest of #24706 as well? |
Andrew Branch (andrewbranch)
approved these changes
Feb 26, 2021
Eli Barzilay (elibarzilay)
approved these changes
Feb 27, 2021
Eli Barzilay (elibarzilay)
left a comment
Eli Barzilay (elibarzilay)
left a comment
Contributor
There was a problem hiding this comment.
No good understanding of the highlevel change, but two picky comments...
1. More early-returns. 2. More line breaks.
Nathan Shively-Sanders (sandersn)
deleted the
add-undefined-to-Symbol.declarations
branch
March 1, 2021 22:32
Member
Author
|
Ahmed Jaffery (@ajaff) I'm going to see how easy it is to fix |
Russell Bicknell (bicknellr)
added a commit
to lit/lit
that referenced
this pull request
Aug 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symbol.declarations now has type
Declaration[] | undefined.