Move deprecate from Debug to deprecatedCompat#51522
Merged
Merged
Conversation
Loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #51443, #51441
This breaks the cycle between
DebugandVersion; while the current state doesn't crash (both bundled and unbundled), it only works due to some careful setup done in #51387. It's possible for a future refactor to break this unintentionally.This was pulled out of #51455. It's a prerequisite for potentially making
Debuga module rather than a namespace but probably also useful for #51504.It also happens to reduce the code size of
tscby a little, since it doesn't use this code, but it's not really a significant amount by any means and isn't the driving force behind the PR.