Skip to content

ExecutableResource no longer accepted string.Empty for the working directory #8732

Description

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

Just came across what appears to be an undocumented breaking change in the 9.2 release. ExecutableResource no longer allows empty strings for working directories, which is the result of this change: 22d5ec4#diff-c1fff1268af848145409d984d2b73e685934ed339bb7c4b3dc8a9867d16d714d

I've hit this when creating ExecutableResource's that are globally installed tools with no need to know about a particular working directory. An example of this is the MCP inspector, see https://github.com/CommunityToolkit/Aspire/pull/625/files#diff-4e582e98af1fe62450f9a799190061a2b906de0b7a975ea1f672289b1216540c

This either should be documented as a breaking change or reverted

Expected Behavior

No response

Steps To Reproduce

No response

Exceptions (if any)

No response

.NET Version info

No response

Anything else?

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

area-app-modelIssues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication‼️regression-from-last-releaseThis used to work in an earlier version of Aspire and we broke it!

Type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions