Fix hiding dismiss on inputs dialog - #10349
Merged
Merged
Conversation
James Newton-King (JamesNK)
requested review from
Adam Ratzman (adamint),
Copilot,
Eric Erhardt (eerhardt) and
Mitch Denny (mitchdenny)
July 12, 2025 00:35
Contributor
There was a problem hiding this comment.
Pull Request Overview
The PR updates the InteractionsInputDialog component to respect the dialog’s ShowDismiss parameter rather than always displaying the dismiss button.
- Bind the
ShowDismissattribute toDialog.Instance.Parameters.ShowDismissinstead of a hardcodedtrue.
Comments suppressed due to low confidence (1)
src/Aspire.Dashboard/Components/Dialogs/InteractionsInputDialog.razor:16
- Consider adding a UI or component test to verify that the ShowDismiss parameter correctly controls the visibility of the dismiss button, ensuring this behavior is covered by tests.
<FluentDialogHeader ShowDismiss="@Dialog.Instance.Parameters.ShowDismiss">
Eric Erhardt (eerhardt)
approved these changes
Jul 12, 2025
Collaborator
|
Baclport this one |
Member
|
Is the Cancel button still going to show? |
Member
Author
|
Yes. It is controlled by |
Member
Author
|
/backport to release/9.4 |
Contributor
|
Started backporting to release/9.4: https://github.com/dotnet/aspire/actions/runs/16233788846 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10345