[Ankit Jain (radical)]

Description

Replace the stapler retry JavaScript harness with C#, following this review feedback.
The C# test delegated fixture setup and assertions to Node just to exercise a
Bash script, adding an unnecessary language hop and runtime dependency.

Run the real script from C# using TemporaryWorkspace and TestProcessRunner.
Small Bash stubs replace xcrun and sleep, avoiding Apple services and real
backoff waits. Six cases check recovery, nonretryable exit 68, and retry
exhaustion for both staple and validate.

Write executable stubs through ExecutableFile.WriteAsync to avoid Linux
ETXTBSY ("Text file busy", exit 126) failures when parallel tests inherit
writable descriptors. The helper writes and sets permissions in a short-lived
child rather than the test host.

Infrastructure guidance now defaults to C# tests and harnesses, with other
languages appropriate when they better suit the behavior under test.

Coverage changes

Coverage intentionally focuses on exit status, attempt count, and backoff.
Additional error/stdout cases, changing-error sequences, argument/quoting,
output-text, and temporary-file cleanup assertions are not retained.

The former per-process timeout is replaced by the existing project timeout.

Validation

• 14 selected tests passed on macOS ARM64, with zero failures or skips.
• Includes the existing executable-writer regression: 1,000 launches while four concurrent tasks start other processes.
• Linux infrastructure CI passed: 2,050 tests, including all six stapler cases and both executable-writer regressions.

Local command: 14 selected tests passed on macOS ARM64

MSBUILDTERMINALLOGGER=false dotnet test --project tests/Infrastructure.Tests/Infrastructure.Tests.csproj --no-launch-profile -- --filter-class '*.MacOSStaplerRetryTests' --filter-class '*.ProcessRunnerTests' --filter-class '*.ExecutableFileTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true' --report-trx --results-directory artifacts/pr-feedback-validation

Fixes # (issue)

Checklist

• Is this feature complete?
  • Yes. Ready to ship.
  • No. Follow-up changes expected.
• Are you including unit tests for the changes and scenario tests if relevant?
  • Yes
  • No
• Did you add public API?
  • Yes
    • If yes, did you have an API Review for it?
      • Yes
      • No
    • Did you add <remarks /> and <code /> elements on your triple slash comments?
      • Yes
      • No
  • No
• Does the change make any security assumptions or guarantees?
  • Yes
    • If yes, have you done a threat model and had a security review?
      • Yes
      • No
  • No

[github-actions]

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 21811

Or

• Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 21811"

[Copilot]

🟡 Changes recommended

The executable test stubs can trigger a Linux ETXTBSY race in parallel tests, so they should be written using the existing ExecutableFile.WriteAsync helper.

1 open issue

• Writing executable stubs in the test host can trigger ETXTBSY · New

What changed in this PR

Replaces the stapler retry test’s JavaScript harness with C# fixtures and assertions, removing its Node dependency while continuing to exercise the real shell script.

Changes:

• Reuses TemporaryWorkspace and TestProcessRunner with Bash stubs for xcrun and sleep.
• Covers recovery, nonretryable failure, and retry exhaustion for both staple and validate.
• Narrows coverage to exit status, attempt counts, and backoff delays; removes the broader harness checks and per-process timeout.

File	Description
tests/​Infrastructure.Tests/​Pipelines/​MacOSStaplerRetryTests.cs	Implements six retry scenarios directly in C# using shared test helpers.
tests/​Infrastructure.Tests/​Pipelines/​macos-stapler-retry.harness.js	Removes the JavaScript fixture and assertion harness.

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

Writing executable stubs from the test host exposes parallel Linux runs to an inherited-descriptor race that can cause ETXTBSY failures (exit 126) instead of exercising the retry scenario.

1 open issue

• Writing executable stubs in the test host can trigger ETXTBSY

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

The C# stapler retry harness migration has no active review issues.

No open issues 🎉

1 resolved since last review

• Writing executable stubs in the test host can trigger ETXTBSY

_{Review effort: Balanced}