[tests] Add more playground apps - #5395
Merged
Ankit Jain (radical) merged 8 commits intoAug 27, 2024
Merged
Conversation
ghost
added
the
area-integrations
Ankit Jain (radical)
added
area-app-model
35 tasks
Ankit Jain (radical)
force-pushed
the
withdockerfile-playground
branch
from
August 23, 2024 05:48
d0380ea to
0bdbfeb
Compare
Ankit Jain (radical)
requested review from
Eric Erhardt (eerhardt) and
Jose Perez Rodriguez (joperezr)
August 23, 2024 22:46
Ankit Jain (radical)
marked this pull request as ready for review
August 24, 2024 00:00
Ankit Jain (radical)
requested a review
from Mitch Denny (mitchdenny)
as a code owner
August 24, 2024 00:00
| .WithBuildArg("GO_VERSION", goVersion) | ||
| .WithBuildSecret("SECRET_ASENV", secret); | ||
| .WithBuildSecret("SECRET_ASENV", secret) | ||
| .WithEnvironment("DOCKER_BUILDKIT", "1"); |
There was a problem hiding this comment.
Do you need this here or in the MSBuild file.
Member
Author
There was a problem hiding this comment.
I set it here to have it close to where it is needed.
There was a problem hiding this comment.
Why do we have it in both places?
Member
Author
There was a problem hiding this comment.
It is set for tests running on the build machine (note to self: can be dropped now), and for basictests on helix.
Eric Erhardt (eerhardt)
approved these changes
Aug 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow