[release/9.1] Add WithParentRelationship overload accepting an IResourceBuilder - #7616
Merged
William Godbe (wtgodbe) merged 1 commit intoFeb 14, 2025
Merged
Conversation
github-actions
Bot
requested a review
from Mitch Denny (mitchdenny)
as a code owner
February 14, 2025 16:58
Damian Edwards (DamianEdwards)
approved these changes
Feb 14, 2025
William Godbe (wtgodbe)
approved these changes
Feb 14, 2025
1 task
github-actions
Bot
added
the
area-app-model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #7615 to release/9.1
/cc Eric Erhardt (@eerhardt)
Customer Impact
It is clunky to call
WithParentRelationshiptoday because it takes just anIResource parent, when callers normally have theIResourceBuilder<T>that they are working with. Adding an overload that takes the builder to resolve this ergononmic issue with the API.Testing
Existing tests were converted to the new API. Everything still works.
Risk
Very low. Just adding a new overload to a new method.
Regression?
No