Use RemoteExecutor for fake CLI process. - #7875
Merged
Mitch Denny (mitchdenny) merged 2 commits intoMar 4, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
PR Overview
This pull request updates the Windows StubProcess implementation to use a long-running ping command instead of a cmd.exe trick.
- Replaces the ProcessStartInfo FileName from cmd.exe to ping.exe
- Updates the Arguments from "/c set /p discard=WaitingUntilDeath" to "-t 127.0.0.1"
Reviewed Changes
| File | Description |
|---|---|
| tests/Aspire.Cli.Tests/Helpers/StubProcess.cs | Replaces outdated Windows StubProcess implementation with a long-running ping command |
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
David Fowler (davidfowl)
approved these changes
Mar 4, 2025
Mitch Denny (mitchdenny)
changed the title
Mitch Denny (mitchdenny)
enabled auto-merge (squash)
March 4, 2025 06:06
github-actions
Bot
added
the
area-integrations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes StubProcess and uses RemoteExecutor instead to improve test reliability/simplicity.