Skip to content

Remove Aspire.Cli from unexpected packages list - #7896

Merged
Mitch Denny (mitchdenny) merged 1 commit into
mainfrom
mitchdenny/fix-cli-package
Mar 5, 2025
Merged

Mitch Denny (mitchdenny) merged 1 commit into
mainfrom
mitchdenny/fix-cli-package

Conversation

@mitchdenny

Copy link
Copy Markdown
Member

Exclude Aspire.Cli from the set of unexpected packages. This is currently breaking the build.

Copilot AI review requested due to automatic review settings March 5, 2025 06:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@mitchdenny

Copy link
Copy Markdown
Member Author

Ankit Jain (@radical) Jose Perez Rodriguez (@joperezr) the build is currently broken because I set Aspire.Cli to be packable (wasn't picked up on PR validation). Is this the correct approach to solve this problem?

@mitchdenny
Mitch Denny (mitchdenny) merged commit 692ec22 into main Mar 5, 2025
@mitchdenny
Mitch Denny (mitchdenny) deleted the mitchdenny/fix-cli-package branch March 5, 2025 07:12
@davidfowl

Copy link
Copy Markdown
Collaborator

Why are these packages still arch specific even though you removed publishaot?

@mitchdenny

Copy link
Copy Markdown
Member Author

They aren't arch specific (at least Aspire.Cli isn't). It just so happens some of these other ones are.

@github-actions github-actions Bot added the area-integrations Issues pertaining to Aspire Integrations packages label Mar 10, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-integrations Issues pertaining to Aspire Integrations packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants