This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Add oAuthEndpoint to _oAuthClients cache key - #6298
Merged
Merged
Conversation
Collaborator
Pull Request Test Coverage Report for Build 301650
💛 - Coveralls |
| OAuthClientConfig.EmulateOAuthCards = true; | ||
| } | ||
|
|
||
| var oAuthEndpoint = OAuthClientConfig.OAuthEndpoint; |
There was a problem hiding this comment.
The assumption is that we should not be calling these from different threads as we are still caching a static variable. A context switch before this line could result in incorrect endpoint being used if two threads set it to different values. I wonder if the approach is to do better documentation or improve synchronization here? Thoughts?
Contributor
Author
There was a problem hiding this comment.
Yes, there will always be a race when using a static like this. As long as we're setting it globally via an FCB I don't think it will matter. For this PR, I wanted to minimize changes and get something that will allow us to change it globally. If we end up needing to set the value on a per-call basis then we'll need another PR to redesign the API and remove the static.
Eric Dahlvang (EricDahlvang)
approved these changes
May 2, 2022
craigjensen
marked this pull request as ready for review
May 2, 2022 22:07
craigjensen
added
the
Automation: No parity
tracyboehrer (tracyboehrer)
pushed a commit
that referenced
this pull request
May 2, 2022
* Add oAuthEndpoint to _oAuthClients cache key * Add CreateOAuthClientWithDifferentEndpoints test Co-authored-by: Craig Jensen <crjens@hotmail.com>
tracyboehrer (tracyboehrer)
added a commit
that referenced
this pull request
May 3, 2022
* Add oAuthEndpoint to _oAuthClients cache key * Add CreateOAuthClientWithDifferentEndpoints test Co-authored-by: Craig Jensen <crjens@hotmail.com> Co-authored-by: craigjensen <cjensen@microsoft.com> Co-authored-by: Craig Jensen <crjens@hotmail.com>
tracyboehrer (tracyboehrer)
pushed a commit
that referenced
this pull request
May 16, 2022
* Add oAuthEndpoint to _oAuthClients cache key * Add CreateOAuthClientWithDifferentEndpoints test Co-authored-by: Craig Jensen <crjens@hotmail.com>
tracyboehrer (tracyboehrer)
added a commit
that referenced
this pull request
May 16, 2022
* Add oAuthEndpoint to _oAuthClients cache key * Add CreateOAuthClientWithDifferentEndpoints test Co-authored-by: Craig Jensen <crjens@hotmail.com> Co-authored-by: craigjensen <cjensen@microsoft.com> Co-authored-by: Craig Jensen <crjens@hotmail.com>
This was referenced Aug 31, 2026
This was referenced Sep 9, 2026
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6308
Description
We cache OAuthClients by appId so changing the endpoint only affects newly created clients that are not already cached. This PR adds the endpoint to the cache key so we can support changing the endpoint at runtime.
Specific Changes
Testing
Added tests for