This repository was archived by the owner on Jan 5, 2026. It is now read-only.
[#6292] Update CosmosDbStorage from Functional to Unit tests - #6303
Merged
Merged
Conversation
Joel Mut (sw-joelmut)
added
the
Automation: No parity
Collaborator
Pull Request Test Coverage Report for Build 304882
💛 - Coveralls |
Contributor
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll |
Contributor
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll |
Gabo Gilabert (gabog)
approved these changes
Jun 8, 2022
This was referenced Aug 31, 2026
This was referenced Sep 9, 2026
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #6292
#minor
Description
This PR removes the existing Functional tests and as a replacement, it adds support for internal testing to the
CosmosDbStorageclass, and introduces all the necessary unit tests, increasing the code coverage up to 86%.Specific Changes
CosmosDbStorage.DocumentStoreItemclass accessibility fromprivatetointernal, so it can be accessed from the tests.CosmosDbStorageTestsclass.CosmosDbStorageTestsclass for each method, constructor, method validations, etc.Testing
The following image shows the new unit tests and the code coverage.
