Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

[#6292] Add unit tests to cover AzureBlobTranscriptStore - #6311

Merged
Gabo Gilabert (gabog) merged 8 commits into
mainfrom
southworks/add/unit-test-azureblobtranscriptstore
Jun 8, 2022
Merged

Gabo Gilabert (gabog) merged 8 commits into
mainfrom
southworks/add/unit-test-azureblobtranscriptstore

Conversation

@ceciliaavila

@ceciliaavila Cecilia Avila (ceciliaavila) commented Apr 28, 2022

Copy link
Copy Markdown
Collaborator

Addresses #6292
#minor

Description

This PR adds unit tests for the AzureBlobTranscriptStore class.

Specific Changes

  • Adds unit tests for the AzureBlobTranscriptStore class.
  • Adds a new internal constructor that receives a CloudBlobClient to be able to pass a mocked instance of this class, allowing to test without the use of emulators.

Testing

This image shows the unit tests passing and the code coverage.
image
image

@ceciliaavila
Cecilia Avila (ceciliaavila) requested a review from a team as a code owner April 28, 2022 17:51
@ceciliaavila Cecilia Avila (ceciliaavila) added the Automation: No parity PR does not need to be applied to other languages. label Apr 28, 2022
@coveralls

Coveralls (coveralls) commented Apr 28, 2022

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 304880

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 25 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 78.948%

Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/ForEachElement.cs 8 90.0%
/libraries/Microsoft.Bot.Builder/BotFrameworkAdapter.cs 17 47.91%
Totals Coverage Status
Change from base Build 302179: 0.2%
Covered Lines: 25374
Relevant Lines: 32140

💛 - Coveralls

@ceciliaavila
Cecilia Avila (ceciliaavila) marked this pull request as draft April 29, 2022 13:01
@ceciliaavila
Cecilia Avila (ceciliaavila) marked this pull request as ready for review April 29, 2022 21:05
@BruceHaley

Copy link
Copy Markdown
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Automation: No parity PR does not need to be applied to other languages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants