Repository navigation
Add metadata-only runtime registration - #1522
Merged
Max Charlamb (max-charlamb) merged 1 commit intoNov 3, 2026
Merged
Max Charlamb (max-charlamb) merged 1 commit into
Max Charlamb (max-charlamb) merged 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3c58bffd-42d4-4832-8df7-d80066a469ff
Contributor
|
Just a draft so I didn't fully review, but this design looks good to me. |
Max Charlamb (max-charlamb)
marked this pull request as ready for review
November 3, 2026 17:32
Lee Culver (leculver)
approved these changes
Nov 3, 2026
Max Charlamb (max-charlamb)
merged commit Nov 3, 2026
cba085b
into
microsoft:main
4 of 10 checks passed
Max Charlamb (max-charlamb)
deleted the
max-charlamb/add-runtime-metadata
branch
November 3, 2026 20:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DataTarget.AddRuntime(ClrInfo)to register host-discovered metadata without requiring a host-supplied DAC interface.AddLoadedRuntime, while keeping validation inline.SkipRuntimeEnumeration = trueand update API documentation.This enables the consumer change requested in dotnet/diagnostics#6010 (comment), avoiding redundant runtime enumeration on production
DataTargetinstances.Validation
DataTargetTestspassed, including metadata registration, replacement, validation, host-registration precedence, and legacy DAC activation with runtime enumeration disabled.netstandard2.0library build passed with no warnings or errors.