fix(installer): improve private-index recovery guidance - #536
Jason Robert (jrob5756) merged 3 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #536 +/- ##
=======================================
Coverage ? 92.30%
=======================================
Files ? 175
Lines ? 28231
Branches ? 0
=======================================
Hits ? 26059
Misses ? 2172
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Jason Robert (jrob5756)
left a comment
There was a problem hiding this comment.
One blocking issue and one test-coverage gap, both around the new pip-to-uv index bridging logic.
Blocking:
install.sh:322— the pip index lookup isn't guarded beforeUV_DEFAULT_INDEXgets set and the installer reruns.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Jason Robert (jrob5756)
left a comment
There was a problem hiding this comment.
Two things from last time are done: the pip-to-uv bridge now guards against an empty lookup, and there's a test asserting the full rendered bridge sequence, not just pieces of it.
Everything else is still open.
CI is red on this commit, reported four separate ways:
- Install Scripts (ubuntu-latest) failed on run 35366975168, attempt 2: https://github.com/microsoft/conductor/actions/runs/35366975168/job/105685803280
- Changelog failed on run 35366975254, attempt 2: https://github.com/microsoft/conductor/actions/runs/35366975254/job/105685698456
- The check "CI / Install Scripts (ubuntu-latest)" is showing FAILURE for that same job.
- The check "Changelog / Changelog" is showing FAILURE for that same job.
All four point at the same two failing jobs. Get the commit green, then re-run review and verify checks before merging.
One more item carried over, recommended rather than blocking: install.sh:322 — the pip index lookup isn't guarded before UV_DEFAULT_INDEX gets set and the installer reruns. There's a test-coverage gap alongside it. The follow-up pass didn't examine this one, so it's coming through unexamined — take a look yourself before deciding whether it needs to block.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Jason Robert (@jrob5756) Addressed the two red checks in a6a4303:
Local validation passed: changelog contract, The refreshed CI and Changelog runs are currently |
Jason Robert (jrob5756)
left a comment
There was a problem hiding this comment.
The empty pip index lookup is guarded now, coverage requires the full rendered bridge, and the changelog issue is fixed. Good progress.
One item from the earlier pass is still open. It was flagged recommended, but it actually bundles a blocking issue with a coverage gap, both in the new pip-to-uv index bridging logic: at install.sh:322, the pip index lookup still isn't guarded before UV_DEFAULT_INDEX gets set and the installer reruns. The follow-up analysis didn't check whether this landed, so I can't confirm it from here — worth a manual look before closing it out.
Still open:
install.sh:322— pip index lookup guard (blocking, per the original point)
|
Manual Windows validation completed on September 22, 2026: |
Summary
UV_SYSTEM_CERTS=1for current uv releases while retaining the legacy setting for uv versions older than 0.11Validation
uv run --frozen ruff check tests/test_integration/test_install_scripts.py tests/test_integration/test_install_script_files.pyuv run --frozen ty check tests/test_integration/test_install_scripts.py tests/test_integration/test_install_script_files.pyinstall.ps1sh -n install.shuv run --frozen pytest -q tests/test_integration/test_install_script_files.py(12 passed)uv run --frozen pytest -q -m install_scripts tests/test_integration/test_install_scripts.py -k "blocked_package_index_reports_guidance or blocked_index_offers_credential_safe_pip_bridge"(2 passed)