Crash in Android 1DS SDK

[saurabh0802chd]

Describe your environment.
SDK Version: 3.5.63

Steps to reproduce.
We have done recent changes on how we were using 1DS to create user-specific loggers. After these changes we are seeing the this crash in our app.

What is the expected behavior?
What did you expect to see?
App should not crash.

What is the actual behavior?
What did you see instead?
App crashing with below error.
[libmaesdk.so] Java_com_microsoft_applications_events_LogManagerProvider_00024LogManagerImpl_nativeGetLogger

Attaching crash stack.
1DS SDK crash.txt

Additional context

[lalitb]

saurabh0802chd - Can you please elaborate what are these recent changes ? Also there are discussions in #808 for similar issue. This seems to be the scenario where LogManager::GetLogger() is returning nullptr because LogManager is no more active which is expected behavior. The Java binding throws null pointer exception in that case. Please ensure the android app is catching that exception.

Also, the issue is specific to the Java binding, and my team doesn't have expertise on it, so eventually you have to debug this issue further. Let me know if you want to me to assign this to you ?

[saurabh0802chd]

Lalit Kumar Bhasin (@lalitb) Thank you for your response.

Our app needs to send events generated for a user to a particular endpoint, for this we have added below code:

private final HashMap<String, ILogManager> mLogManagersByEndPoint; if(!mLogManagersByEndPoint.containsKey(endPoint)) { logManager = LogManagerProvider.createLogManager(someLogConfiguration); mLogManagersByEndPoint.put(endPoint, logManager); } else { logManager = mLogManagersByEndPoint.get(endPoint); } logger = logManager.getLogger(mTenantId, "", "");

We are keeping LogManager instances in a hashmap to reuse them for a particular configuration. By any chance map can have a LogManager which is no more active?

[lalitb]

saurabh0802chd What are the values for "name" and "host" attributes used in the log-configuration for each of these user's logmanagers.

[saurabh0802chd]

Lalit Kumar Bhasin (@lalitb) We are setting endPoint as "host" and UUID.randomUUID() as "name".

[lalitb]

We are setting endPoint as "host" and UUID.randomUUID() as "name".

This seems fine to me. From 1ds-sdk c++ code, log-manager would be invalidated only when explicitly done (using delete, flushAndTearDown, close). I am not fully familiar with the JNI layer. If you are able to reproduce this consistently, you would be the best to debug this further :)

[saurabh0802chd]

Lalit Kumar Bhasin (@lalitb) We are not invalidating the LogManager's instance explicitly. The crash is happening for few users only and I am not able to reproduce it on my devices.