Repository navigation
Add CentOS8 and Debian10 support - #820
Merged
Merged
Conversation
Vitalii Herasimov (vgerasimovms)
requested a review
from Max Golovanov (maxgolov)
April 5, 2021 18:46
Vitalii Herasimov (vgerasimovms)
changed the title
| #!/bin/sh | ||
|
|
||
| if [ -f /bin/yum ]; then | ||
| if [ `cat /etc/os-release | grep CentOS-7` != "" ]; then |
Contributor
There was a problem hiding this comment.
nit: this one is a bit sketchy..
Contributor
There was a problem hiding this comment.
I mean maybe we need to have a separate notes / document in markdown format that elaborates on this, build toos setup depending on OS, etc. Maybe in the Linux build instructions doc.
Contributor
Author
There was a problem hiding this comment.
I think it would be better to move all these installations to docker file, since docker image creation happens during the build
Max Golovanov (maxgolov)
approved these changes
Apr 12, 2021
Max Golovanov (maxgolov)
approved these changes
Apr 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.