Add theap stats retrieval - #1366
Merged
Merged
Conversation
Collaborator
|
Nice. My only worry is that it is unsafe to get the stats from a theap that is not the current thread's theap. But perhaps best to still expose it for systems that pause the threads anyway to gather precise stats? |
Contributor
Author
|
Given the whole theap idea is "thread-local heaps", I think this "unsafe" stats retrieval fits into that idea - you may be able to retrieve stats from some other thread, but you're not really supposed to. |
Collaborator
|
Agreed :-) Thanks Frank. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
theaps already track stats internally - expose them for those who'd like to make use of them (for example, to track the current thread's allocations).