Skip to content

Work around clang-cl missing ldar, stlr - #1379

Closed
Frank Richter (res2k) wants to merge 1 commit into
microsoft:dev3from
res2k:fix-clang-cl-missing-ldar-stlr
Closed

Work around clang-cl missing ldar, stlr#1379
Frank Richter (res2k) wants to merge 1 commit into
microsoft:dev3from
res2k:fix-clang-cl-missing-ldar-stlr

Conversation

@res2k

@res2k Frank Richter (res2k) commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

The problematic code paths are hit when using clang-cl in C mode.

Fall through to code paths not using.

Disclaimer: This was purely done to fix builds, I didn't check the extend this affects performance.

@res2k
Frank Richter (res2k) marked this pull request as ready for review August 28, 2026 15:52
@daanx
Daan (daanx) changed the base branch from dev3 to dev August 28, 2026 18:01
@daanx
Daan (daanx) changed the base branch from dev to dev3 August 28, 2026 18:02
@daanx

Copy link
Copy Markdown
Collaborator

Thanks Frank. I applied it to the dev branch instead, hope that is ok. Thanks again.

@res2k

Copy link
Copy Markdown
Contributor Author

Thanks Frank. I applied it to the dev branch instead, hope that is ok. Thanks again.

Sure - I filed the PR against dev3 since I've seen this being an issue in 3.5.0.

@daanx

Copy link
Copy Markdown
Collaborator

Ah, dev is upstream of both dev2 and dev3 so it'll flow in to dev3 already.
Generally, PR's should go against dev if it applies to all versions. (well, I am trying to only apply security and build fixes to dev and dev2 nowadays to keep them stable).
The other PR to add C/CXX tests to the workflow is ok to only do for dev3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants