Add guidelines for ORTModule - #13553
Merged
Merged
Conversation
pengwa
added
the
training
pengwa
requested review from
Vincent Wang (Lafi7e),
Ashwini Khade (askhade),
Baiju Meswani (baijumeswani),
mindest and
zhijiang (zhijxu-MS)
November 3, 2022 07:58
mindest
reviewed
Nov 3, 2022
mindest
left a comment
mindest
left a comment
Contributor
There was a problem hiding this comment.
Thanks for summarizing these helpful tips. Comments mainly for some typos.
mindest
reviewed
Nov 3, 2022
Baiju Meswani (baijumeswani)
previously approved these changes
Nov 4, 2022
Baiju Meswani (baijumeswani)
left a comment
Baiju Meswani (baijumeswani)
left a comment
Contributor
There was a problem hiding this comment.
Nice doc.
Contributor
Author
|
Add section for "ORTModule is NOT compatible with torch.nn.DataParallel" as PeixuanZuo previously experienced. |
mindest
approved these changes
Nov 4, 2022
MS (simon-moo)
pushed a commit
to simon-moo/onnxruntime
that referenced
this pull request
Dec 21, 2022
### Add guidelines for ORTModule As title. Feel free to let me know if I missed something. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add guidelines for ORTModule
As title.
Feel free to let me know if I missed something.
Motivation and Context