adding get and set lr for optimizer - #13661
Merged
Merged
Conversation
Adam Louly (AdamLouly)
requested review from
Ashwini Khade (askhade) and
Baiju Meswani (baijumeswani)
November 16, 2022 00:30
Baiju Meswani (baijumeswani)
added
the
training
| """ | ||
| self._optimizer.optimizer_step() | ||
|
|
||
| def set_learning_rate(self, learning_rate): |
Contributor
There was a problem hiding this comment.
let's add type hints if possible.
| optimizer = Optimizer(optimizer_file_path, model) | ||
|
|
||
| # Test get and set learning rate. | ||
| lr = optimizer.get_learning_rate() |
Contributor
There was a problem hiding this comment.
Can you test the default learning rate?
| optimizer.set_learning_rate(0.5) | ||
| new_lr = optimizer.get_learning_rate() | ||
|
|
||
| assert lr != new_lr |
Contributor
There was a problem hiding this comment.
add assert isclose(new_lr, 0.5)?
Baiju Meswani (baijumeswani)
previously approved these changes
Dec 5, 2022
Baiju Meswani (baijumeswani)
approved these changes
Dec 5, 2022
Contributor
Author
|
Thanks for the review |
Baiju Meswani (baijumeswani)
pushed a commit
that referenced
this pull request
Dec 13, 2022
### Description Exposing get and set Learning rate for optimizer ### Motivation and Context you can now set learning rate for optimizer.
MS (simon-moo)
pushed a commit
to simon-moo/onnxruntime
that referenced
this pull request
Dec 26, 2022
### Description Exposing get and set Learning rate for optimizer ### Motivation and Context you can now set learning rate for optimizer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Exposing get and set Learning rate for optimizer
Motivation and Context
you can now set learning rate for optimizer.