Fix invocation of GetInputMemoryType. - #13828
Merged
Merged
Conversation
Hariharan Seshadri (hariharans29)
approved these changes
Dec 2, 2022
Fei Hu (feihugis)
approved these changes
Dec 3, 2022
Fei Hu (feihugis)
left a comment
Fei Hu (feihugis)
left a comment
Contributor
There was a problem hiding this comment.
Thanks Pranav Sharma (@pranavsharma) for the fix! LGTM.
Baiju Meswani (baijumeswani)
pushed a commit
that referenced
this pull request
Dec 13, 2022
### Description GetInputMemoryType was introduced in ver 13 in [this PR](#10879). The ver check introduced in this PR allows custom ops compiled using older versions to work with newer versions (> 12) of the ORT binary. ### Motivation and Context Fixes binary compatibility.
MS (simon-moo)
pushed a commit
to simon-moo/onnxruntime
that referenced
this pull request
Dec 26, 2022
### Description GetInputMemoryType was introduced in ver 13 in [this PR](microsoft#10879). The ver check introduced in this PR allows custom ops compiled using older versions to work with newer versions (> 12) of the ORT binary. ### Motivation and Context Fixes binary compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GetInputMemoryType was introduced in ver 13 in this PR. The ver check introduced in this PR allows custom ops compiled using older versions to work with newer versions (> 12) of the ORT binary.
Motivation and Context
Fixes binary compatibility.