Show performance number as ms instead of second - #142
Merged
Merged
Conversation
Changming Sun (snnn)
approved these changes
Dec 10, 2018
Ted Themistokleous (TedThemistokleous)
pushed a commit
to TedThemistokleous/onnxruntime
that referenced
this pull request
Jul 9, 2025
…icrosoft#142) * Correct tidy warnings for MIGraphX Execution Provider * incorporate review feedback * lintrunner
Dmitri Smirnov (yuslepukhin)
pushed a commit
that referenced
this pull request
Mar 17, 2026
We use pydantic models for our config classes. By default, pydantic models ignore parameters that are not part of the config class. This is a desirable feature but we should warn the user if the config dict they provided has such parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's annoying to multipy by 1000 to get cost in ms manually