Skip to content

Exclude padding section from minimal build size report #22578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Scott McKay (skottmckay) merged 3 commits into from
Oct 24, 2024
Merged

Exclude padding section from minimal build size report #22578

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d8150f
Exclude relro_padding section
skottmckay Oct 11, 2024
f3fcef0
Fix comparison
skottmckay Oct 11, 2024
9f74c1e
Merge remote-tracking branch 'origin/main' into skottmckay/ExcludePad…
skottmckay Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tools/ci_build/github/linux/ort_minimal/readelf_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,13 @@ def get_section_sizes(binary_path, readelf_path, dump_to_file=None):
for match in re.finditer(r"\[[\s\d]+\] (\..*)$", output, re.MULTILINE):
items = match.group(1).split()
name = items[0]
if name == ".relro_padding":
# padding fluctuates and isn't due to the actual code. as it adds noise to the diff exclude it
continue

# convert size from hex to int
size = int(items[4], 16)

section_sizes[name] = size

if dump_to_file:
Expand Down