Skip to content

Integration with ONNX 1.19 - #25678

Merged
Ti-Tai Wang (titaiwangms) merged 37 commits into
microsoft:mainfrom
titaiwangms:titaiwang/test_onnx_1_19
Sep 6, 2025
Merged

Ti-Tai Wang (titaiwangms) merged 37 commits into
microsoft:mainfrom
titaiwangms:titaiwang/test_onnx_1_19

Conversation

@titaiwangms

@titaiwangms Ti-Tai Wang (titaiwangms) commented Aug 7, 2025 •

Copy link
Copy Markdown
Contributor

Description

Update ONNX to v1.19.0
The major updates of ONNX: https://github.com/onnx/onnx/wiki/Logistics-for-ONNX-Release-1.19.0

Remaining Issues

  1. Additional inputs nonpad_kv_seqlen to op.Attentnio since opset24
  2. Attention implementation bugs in CPU: test_attention_4d_with_past_and_present_qk_matmul_bias_3d_mask_causal and test_attention_4d_with_past_and_present_qk_matmul_bias_4d_mask_causal
  3. New op TensorScatter
  4. New op Swish
  5. ml_dtypes replaces custom_element_types in ONNX Use ml_dtypes everywhere onnx/onnx#7089

@titaiwangms Ti-Tai Wang (titaiwangms) changed the title [WIP] Test integration with ONNX 1.19 Integration with ONNX 1.19 Aug 28, 2025
@titaiwangms

Copy link
Copy Markdown
Contributor Author

Need to fix ml_dtypes issues.

@titaiwangms

Copy link
Copy Markdown
Contributor Author

Changming Sun (@snnn) Could you help me confirm whether these 4 CI failures are related or not (I think it's unrelated.).

Comment thread cmake/deps.txt
@snnn

Copy link
Copy Markdown
Contributor

Will check. Sorry, I was working on an ORT release. There were a lot of pipeline problems there.

@titaiwangms

Copy link
Copy Markdown
Contributor Author

Will check. Sorry, I was working on an ORT release. There were a lot of pipeline problems there.

Can I directly merge this PR if it's only these failures? There would be more works to move them to a new branch under official repo.

@titaiwangms
Ti-Tai Wang (titaiwangms) merged commit ecb26fb into microsoft:main Sep 6, 2025
97 of 103 checks passed
@@ -1,2 +1,2 @@
onnx==1.17.0
onnx==1.18.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.19?

Ti-Tai Wang (titaiwangms) added a commit to titaiwangms/onnxruntime that referenced this pull request Jun 2, 2026
ONNX 1.22 re-registers Range with an opset-27 schema (adds stash_type attr, widens type constraints; signature unchanged: 3 scalar inputs -> 1-D output).

- gather_fusion.cc: add 27 to GatherToSlice Range version list {1,11}->{1,11,27}; add opset-27 GatherToSliceFusion test.
- embed_layer_norm_fusion.cc: add 27 to the two Range path matchers (parent_path_3/4) so the embedding fusion still matches opset-27 models.
- coreml/nnapi/vsinpu/webnn base_op_builder.h: bump default GetMaxSupportedOpSet 25->27, matching the lockstep convention of prior ONNX-integration PRs (microsoft#26579, microsoft#25678, microsoft#24449) so opset-27 nodes are not spuriously rejected.

qdq_util.cc / layout_transformation_potentially_added_ops.h / kernel_type_str_resolver_utils.cc were checked and need no change (none reference the opset-27 ops Range/CausalConvWithState/LinearAttention).

Agent-signed-off: Developer (0ede529c) [claude-opus-4.6 via copilot]
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ti-Tai Wang (titaiwangms) added a commit to titaiwangms/onnxruntime that referenced this pull request Jun 15, 2026
ONNX 1.22 re-registers Range with an opset-27 schema (adds stash_type attr, widens type constraints; signature unchanged: 3 scalar inputs -> 1-D output).

- gather_fusion.cc: add 27 to GatherToSlice Range version list {1,11}->{1,11,27}; add opset-27 GatherToSliceFusion test.
- embed_layer_norm_fusion.cc: add 27 to the two Range path matchers (parent_path_3/4) so the embedding fusion still matches opset-27 models.
- coreml/nnapi/vsinpu/webnn base_op_builder.h: bump default GetMaxSupportedOpSet 25->27, matching the lockstep convention of prior ONNX-integration PRs (microsoft#26579, microsoft#25678, microsoft#24449) so opset-27 nodes are not spuriously rejected.

qdq_util.cc / layout_transformation_potentially_added_ops.h / kernel_type_str_resolver_utils.cc were checked and need no change (none reference the opset-27 ops Range/CausalConvWithState/LinearAttention).

Agent-signed-off: Developer (0ede529c) [claude-opus-4.6 via copilot]
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants