Skip to content

Fill CUDA EP opset gap for Sin and Cos operators (7→22) - #27756

Merged
Tianlei Wu (tianleiwu) merged 5 commits into
mainfrom
copilot/update-cos-sin-onnx-operators
May 12, 2026
Merged

Fill CUDA EP opset gap for Sin and Cos operators (7→22)#27756
Tianlei Wu (tianleiwu) merged 5 commits into
mainfrom
copilot/update-cos-sin-onnx-operators

Conversation

Copilot AI commented Mar 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Cap existing opset 7 Sin/Cos kernels to versioned 7-21
  • Add new opset 22 Sin/Cos kernels with BFloat16 support (HFDX)
  • Update forward declarations and BuildKernelCreateInfo entries
  • Add opset 22 tests for Sin and Cos
  • Rebase onto latest main, resolve conflicts
  • Merge commit with latest main to resolve conflicts

@tianleiwu
Fill CUDA EP opset gap for Sin and Cos operators (7→22)
bd9dddc 
- Cap existing opset 7 kernels to versioned 7-21
- Add new opset 22 kernels with BFloat16 support (HFDX)
- Update forward declarations and BuildKernelCreateInfo entries
- Add opset 22 tests for Sin and Cos

Co-authored-by: tianleiwu <30328909+tianleiwu@users.noreply.github.com>
@tianleiwu Tianlei Wu (tianleiwu) mentioned this pull request Mar 19, 2026
Open
@justinchuby

Justin Chu (justinchuby) commented May 9, 2026

Copy link
Copy Markdown
Contributor

This is quite important. Copilot please update and rebase

Copilot AI and others added 2 commits May 9, 2026 15:18
@justinchuby
Fill CUDA EP opset gap for Sin and Cos operators (7→22)
8cb8a0e 
- Cap existing opset 7 kernels to versioned 7-21
- Add new opset 22 kernels with BFloat16 support (HFDX)
- Update forward declarations and BuildKernelCreateInfo entries
- Add opset 22 tests for Sin and Cos

Agent-Logs-Url: https://github.com/microsoft/onnxruntime/sessions/e24e753b-b51e-4758-91a2-b87f4fdb2460

Co-authored-by: justinchuby <11205048+justinchuby@users.noreply.github.com>
Merge remote branch for rebase
fb258fe 
Co-authored-by: justinchuby <11205048+justinchuby@users.noreply.github.com>

Copilot AI commented May 9, 2026

Copy link
Copy Markdown
Contributor Author

This is quite important. Copilot please update and rebase

Rebased onto latest main and resolved merge conflicts with Round, RoiAlign, RNN, and GridSample opset gap fill changes that landed since the original commit. The Sin/Cos changes are now applied cleanly on top of the current main at fb258fe.

@justinchuby

Justin Chu (justinchuby) commented May 9, 2026

Copy link
Copy Markdown
Contributor

Copilot resolve the merge conflicts in this pull request maybe create a merge commit

@justinchuby
Justin Chu (justinchuby) marked this pull request as ready for review May 9, 2026 15:22
@justinchuby
Merge remote-tracking branch 'origin/main' into copilot/update-cos-si…
850a471 
…n-onnx-operators

# Conflicts:
#	onnxruntime/core/providers/cuda/cuda_execution_provider.cc
#	onnxruntime/core/providers/cuda/math/unary_elementwise_ops.cc

Co-authored-by: justinchuby <11205048+justinchuby@users.noreply.github.com>

Copilot AI commented May 9, 2026

Copy link
Copy Markdown
Contributor Author

Copilot resolve the merge conflicts in this pull request maybe create a merge commit

Resolved the merge conflicts with origin/main via merge commit 850a471. All three conflict sites (forward declarations, BuildKernelCreateInfo entries, and unary_elementwise_ops registrations) were resolved by keeping our Sin/Cos opset 22 additions alongside the changes that landed on main.

@tianleiwu
Tianlei Wu (tianleiwu) enabled auto-merge (squash) May 11, 2026 16:31
@tianleiwu
Tianlei Wu (tianleiwu) merged commit 480aad0 into main May 12, 2026
88 checks passed
@tianleiwu
Tianlei Wu (tianleiwu) deleted the copilot/update-cos-sin-onnx-operators branch May 12, 2026 20:58
@BrewTestBot BrewTestBot mentioned this pull request Jun 19, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hariharans29 Hariharan Seshadri (hariharans29) hariharans29 approved these changes
@justinchuby Justin Chu (justinchuby) Awaiting requested review from justinchuby
@apsonawane Akshay Sonawane (apsonawane) Awaiting requested review from apsonawane
+1 more reviewer
@tianleiwu Tianlei Wu (tianleiwu) tianleiwu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tianleiwu Tianlei Wu (tianleiwu)

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@justinchuby @hariharans29 @tianleiwu