Fix Flash and Lean attention split heuristics - #29554
Merged
Tianlei Wu (tianleiwu) merged 2 commits intoJul 6, 2026
Merged
Tianlei Wu (tianleiwu) merged 2 commits into
Tianlei Wu (tianleiwu) merged 2 commits into
Conversation
kunal-vaishnavi
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes split heuristic edge cases in Flash Attention and Lean Attention when the SM count is reported as zero or when there are no key tiles. The change clamps the SM count used by the heuristics, prevents divide-by-zero paths, and returns stable buffer sizing for empty tile cases.
Changes
Testing
attention_split_heuristic_test.cccoverage for Flash Attention and Lean Attention split heuristics.Fixes #29550