Update Android minimal size baseline - #32772
Merged
David Fan (jiafatom) merged 1 commit intoSep 24, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused threshold update is internally consistent and matches the documented deterministic binary size.
Review effort: Balanced
Findings: None
What changed in this PR
Raises the Android minimal-build size limit by 1 KiB to restore CI while retaining 387 bytes of headroom.
Changes:
- Updates the displayed and enforced threshold from 1,595,392 to 1,596,416 bytes.
- No actionable issues found.
| File | Description |
|---|---|
.github/workflows/android.yml |
Raises the Android minimal binary-size threshold consistently. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Akshay Sonawane (apsonawane)
approved these changes
Sep 23, 2026
David Fan (jiafatom)
enabled auto-merge (squash)
September 23, 2026 23:27
David Fan (jiafatom)
deleted the
jiafa/fix-android-minimal-size-baseline
branch
September 24, 2026 00:37
adrastogi
added a commit
that referenced
this pull request
Sep 25, 2026
### Description Raise the Android minimal baseline threshold by 3 KiB, from 1,440,768 to 1,443,840 bytes. The security fixes cherry-picked for 1.28.3 add validation to code that is compiled into the minimal build (session state finalization, execution frame, Loop/Scan subgraph handling). The deterministic section total grows from 1,440,538 bytes (rel-1.28.3 base, run 36072293072) to 1,443,098 bytes (+2,560 bytes), exceeding the old threshold by 2,330 bytes. The new threshold leaves 742 bytes of headroom. This is a release-branch-only change; main tracks its own baseline (see #32772). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Raise the Android minimal baseline threshold by 1 KiB, from 1,595,392 to 1,596,416 bytes.
Latest
mainproduces a deterministic section total of 1,596,029 bytes, exceeding the stale threshold by 637 bytes. The same output is reproduced across multiple runners and unrelated PRs, andmainAndroid CI is currently failing. The new threshold leaves 387 bytes of headroom.Validation
git diff --check