Repository navigation
Fix WASM Debug external-data test failures - #33226
Merged
Merged
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: tianleiwu <30328909+tianleiwu@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job wasm_Debug / build-wasm
Fix WASM Debug external-data test failures
Oct 9, 2026
Tianlei Wu (tianleiwu)
marked this pull request as ready for review
October 9, 2026 05:15
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The guards match the WASM loader contract while preserving supported compile and native coverage.
0 open findings
What changed in this PR
Updates WASM test guards for unsupported file-backed external data loading. No actionable issues found.
Changes:
- Retains compile-output assertions while skipping unsupported WASM runtime cases.
- Excludes a host-filesystem initializer test on Emscripten.
| File | Description |
|---|---|
onnxruntime/test/framework/inference_session_test.cc |
Adds targeted Emscripten guards around external-data runtime tests. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Tianlei Wu (tianleiwu)
enabled auto-merge (squash)
October 9, 2026 05:17
Tianlei Wu (tianleiwu)
approved these changes
Oct 9, 2026
Baiju Meswani (baijumeswani)
approved these changes
Oct 9, 2026
Edward Chen (edgchen1)
pushed a commit
that referenced
this pull request
Oct 22, 2026
### Description <!-- Describe your changes. --> - Preserve compile-output checks while skipping file-backed runtime cases unsupported by the WASM test module. - Exclude the host-filesystem external-initializer test on Emscripten; retain native coverage. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to it here. --> The `wasm_Debug / build-wasm` job failed because these tests attempted to load external data without a `Module.MountedFiles` mapping. WASM’s test module does not provide that mapping. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: tianleiwu <30328909+tianleiwu@users.noreply.github.com>
eserscor
pushed a commit
that referenced
this pull request
Oct 22, 2026
### Description <!-- Describe your changes. --> - Preserve compile-output checks while skipping file-backed runtime cases unsupported by the WASM test module. - Exclude the host-filesystem external-initializer test on Emscripten; retain native coverage. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to it here. --> The `wasm_Debug / build-wasm` job failed because these tests attempted to load external data without a `Module.MountedFiles` mapping. WASM’s test module does not provide that mapping. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: tianleiwu <30328909+tianleiwu@users.noreply.github.com>
Edward Chen (edgchen1)
added a commit
that referenced
this pull request
Oct 22, 2026
### Description <!-- Describe your changes. --> This cherry-picks the following commits for the release: | Commit ID | PR Number | Commit Title | |-----------|-----------|-------------| | 1f4b965 | #33526 | Fix WebGPU bundled Dawn platform cleanup | | 2297e77 | #33226 | Fix WASM Debug external-data test failures | ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> WebGPU EP release. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: tianleiwu <30328909+tianleiwu@users.noreply.github.com> Copilot-Session: 9bab1fc9-3c49-4110-91c4-5097c3373dd5 Copilot-Session: 5f4f7562-11aa-4473-afeb-c8e1206de604
eserscor
added a commit
that referenced
this pull request
Oct 23, 2026
### Description <!-- Describe your changes. --> Prepare the ONNX Runtime 1.31.1 patch release targeting `rel-1.31.1`: - Bump native, Python, and JavaScript package versions from 1.31.0 to 1.31.1, including lockfiles, Node.js native-package install metadata, API version assertions, and the Python release-notes link. - Backport the OpenVINO provider-info namespace fix from [#33327](#33327): move the forward declaration to the global namespace and explicitly qualify the type in the optional-provider probe test. - Backport the WASM Debug external-data test fix from [#33226](#33226): skip file-backed cases that require `Module.MountedFiles`, while retaining buffer-destination coverage. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> Keep release metadata aligned for 1.31.1 and include targeted fixes for OpenVINO-enabled Python builds and WASM Debug tests. The OpenVINO change corrects a mismatched type declaration; the WASM changes avoid external-data filesystem paths unsupported by the test module without changing runtime behavior. --------- Co-authored-by: Mustapha Jaber <mustjab@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: tianleiwu <30328909+tianleiwu@users.noreply.github.com>
1 task done
5 of 6 tasks
This was referenced Oct 28, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
The
wasm_Debug / build-wasmjob failed because these tests attempted to load external data without aModule.MountedFilesmapping. WASM’s test module does not provide that mapping.