Repository navigation
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
Author
|
Sushanth Rajasankar (@sushraja-msft) Please review |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The declarations now use the correct global OpenVINO type without changing production behavior.
0 open findings
What changed in this PR
Fixes the OpenVINO legacy build by keeping test-only declarations out of the provider bridge header.
Changes:
- Moves the OpenVINO probe forward declarations into the relevant test.
- Restores the provider bridge header to production declarations only.
| File | Description |
|---|---|
onnxruntime/test/shared_lib/optional_provider_probe_test.cc |
Adds test-local probe declarations. |
onnxruntime/core/session/provider_bridge_ort.h |
Removes conflicting test-only declarations. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Jambay Kinley (jambayk)
approved these changes
Oct 13, 2026
Jambay Kinley (jambayk)
enabled auto-merge (squash)
October 13, 2026 19:55
Contributor
Author
|
#33327 Duplicate PR , please merge this instead. |
auto-merge was automatically disabled
October 14, 2026 16:28
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#33112 introduced bug in Legacy Build of OpenVINO
Motivation and Context
This changes is required because the PR added a struct which was just needed for the test.