Skip to content

Fix CUDA CICD. Remove unnecessary image override. - #33489

Merged
Tianlei Wu (tianleiwu) merged 1 commit into
mainfrom
dev/erscor/2026/10/20-fix-cicd
Oct 20, 2026
Merged

Tianlei Wu (tianleiwu) merged 1 commit into
mainfrom
dev/erscor/2026/10/20-fix-cicd

Conversation

@eserscor

Copy link
Copy Markdown
Contributor

This pull request updates several GitHub Actions workflow files related to Linux CUDA and TensorRT CI jobs. The main change is the removal of the 1ES.ImageOverride=onnxruntime-ubuntu2204-CUDA-A10 setting from the runs-on configuration in multiple workflows. This may allow the jobs to use the default image for the specified pool, potentially improving maintainability or compatibility.

Workflow configuration updates:

  • Removed the 1ES.ImageOverride=onnxruntime-ubuntu2204-CUDA-A10 line from the runs-on section in the following workflow files:
    • .github/workflows/linux_cuda_ci.yml
    • .github/workflows/linux_cuda_no_cudnn.yml
    • .github/workflows/linux_cuda_plugin_ci.yml
    • .github/workflows/linux_tensorrt_ci.yml

Copilot AI balanced review requested due to automatic review settings October 20, 2026 12:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Successful CI runs or maintainer confirmation are needed to establish that the default image supports compatible NVIDIA drivers and GPU-enabled containers.

No open issues 🎉

What changed in this PR

Updates ONNX Runtime’s Linux GPU CI workflows to use the A10 runner pool’s default image.

Changes:

  • Removes the image override from four CUDA and TensorRT workflows.
  • Preserves runner pool selection and job identifiers.

No actionable code issues were identified.

File Description
.github/​workflows/​linux_tensorrt_ci.yml Uses the default image for TensorRT CI.
.github/​workflows/​linux_cuda_plugin_ci.yml Uses the default image for CUDA plugin CI.
.github/​workflows/​linux_cuda_no_cudnn.yml Uses the default image for CUDA testing without cuDNN.
.github/​workflows/​linux_cuda_ci.yml Uses the default image for CUDA CI.

Review effort: Balanced

@tianleiwu
Tianlei Wu (tianleiwu) enabled auto-merge (squash) October 20, 2026 16:39
@tianleiwu
Tianlei Wu (tianleiwu) merged commit ef1d811 into main Oct 20, 2026
122 of 125 checks passed
@tianleiwu
Tianlei Wu (tianleiwu) deleted the dev/erscor/2026/10/20-fix-cicd branch October 20, 2026 18:02
adrastogi pushed a commit that referenced this pull request Oct 26, 2026
This pull request updates several GitHub Actions workflow files related
to Linux CUDA and TensorRT CI jobs. The main change is the removal of
the `1ES.ImageOverride=onnxruntime-ubuntu2204-CUDA-A10` setting from the
`runs-on` configuration in multiple workflows. This may allow the jobs
to use the default image for the specified pool, potentially improving
maintainability or compatibility.

Workflow configuration updates:

* Removed the `1ES.ImageOverride=onnxruntime-ubuntu2204-CUDA-A10` line
from the `runs-on` section in the following workflow files:
  * `.github/workflows/linux_cuda_ci.yml`
  * `.github/workflows/linux_cuda_no_cudnn.yml`
  * `.github/workflows/linux_cuda_plugin_ci.yml`
  * `.github/workflows/linux_tensorrt_ci.yml`

(cherry picked from commit ef1d811)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3eb3fc9b-6147-4706-b7ad-47bb3476377b
adrastogi added a commit that referenced this pull request Oct 27, 2026
### Description
<!-- Describe your changes. -->
This cherry-picks the following commits for the release:

* #32610
* #32633
* #32641
* #32611
* #32609
* #32607
* #32679
* #32681
* #32666

CI fixes:

* #32559 (`8ec7981a7439546a54196b9cbc777ae5de708b6b`): guard FP8 XQA
test cases by GPU compute capability. The Windows CUDA runner is an SM86
A10, while FP8 XQA requires SM89 or SM90+. INT4/INT8 XQA coverage
remains enabled on supported SM80+ devices. This fixes the two FP8
dispatch assertions without changing product behavior.
* Raise the Android minimal baseline binary-size threshold by 1 KiB,
from 1,589,248 to 1,590,272 bytes (release branch only). CI reports a
section total of 1,590,022 bytes, exceeding the previous threshold by
774 bytes. The adjusted threshold leaves 250 bytes of headroom.
* #32676, then #33489: rename the old `A10-Test` image and remove the
unnecessary image override, in upstream order.
* #33492: backport the scale-set runner migration across the release
branch's 41 affected workflows. The Linux CUDA, CUDA Plugin, and
TensorRT test jobs now use `ort-github-linux-6-a10-scus-ss`. Their
previous retries were cancelled by `1es-resource-management[bot]` before
any steps executed.

The first ten cherry-picks, plus #32676 and #33489, applied cleanly from
the original mainline commits, with source commit provenance preserved.
#32607 includes the full mainline fix and regression tests rather than
the reduced 1.28.3 backport.

#33492 required conflict resolution because the release branch has an
older workflow layout:

* Preserve the existing Linux CI and Linux WebGPU job sets; do not
introduce main-only no-exceptions or static-plugin jobs.
* Leave `windows_arm64_python.yml` absent. It was introduced after 1.30
branched by #32791; its runner migration does not require adding that
workflow to this release.
* Preserve Windows WebGPU's combined build/test jobs and their check
names, keeping them on the new GPU scale set rather than importing
main's split build/test topology. The build-only minimal Edge job uses
the new CPU scale set.

### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
Bring the product fixes from #32806 into ORT 1.30.1, address the Windows
CUDA test and Android size-gate failures, and migrate CI runner
selection to unblock the cancelled GPU jobs.

The merged EP API version correction from #33525 was brought in by
merging the updated `rel-1.30.1` base. The `uuid-dev` CI fix in #32491
was already present in the 1.30 base and is not duplicated.

The OpenVINO changes in #33112 and #33327 are intentionally excluded:
the namespace regression fixed by #33327 was introduced by #33112, and
neither change is present in the 1.30 base.

Validation:

* All nine original product cherry-pick patch IDs were verified against
their mainline commits; the additional #32559 patch ID also matches
upstream.
* The upstream `test_fp8_xqa_cuda_capability` regression passed in an
isolated standard-library harness using mocked SM86, SM89, and SM90
capabilities. Additional no-CUDA and external-runner cases passed.
* Python syntax and Android threshold consistency/arithmetic checks
passed.
* `git diff --check 3b0f46f HEAD` passed.
* All 41 migrated workflow YAML files parse. Structural comparisons
against the pre-migration release workflows confirm that only runner
labels, caller pool names, and the reusable pool-input description
changed; job sets, steps, triggers, permissions, matrices, and build
flags are preserved.
* All 13 callers of the reusable Linux build workflow use scale-set pool
names; all three previously cancelled GPU test jobs use the new A10
scale set.
* The Android release-specific size threshold remains 1,590,272 bytes.
* The full helper pytest invocation was not runnable because pytest is
not installed in the local virtual environment. No local GPU execution
or Android rebuild was performed; CI will validate the integrated
changes.

---------

Co-authored-by: Wei Wang <wei4.wang@intel.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: shiyi <shiyi.zou@intel.com>
Co-authored-by: Bin Miao <bin.miao@intel.com>
Co-authored-by: Bryan B <bryan.bernhart@intel.com>
Co-authored-by: Xiaofei Han <xiaofeihan@microsoft.com>
Co-authored-by: Aditya Rastogi <adityar@ntdev.microsoft.com>
Co-authored-by: Tianlei Wu <tlwu@microsoft.com>
Co-authored-by: eserscor <erscor@microsoft.com>
Copilot-Session: 3eb3fc9b-6147-4706-b7ad-47bb3476377b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants