Add NonMaxSupression op to contribution ops - #60
Merged
Merged
Conversation
Hector Li (HectorSVC)
requested review from
Ke Zhang (linkerzhang) and
Wenbing Li (wenbingl)
November 29, 2018 19:08
Wenbing Li (wenbingl)
previously approved these changes
Nov 29, 2018
| bool SuppressByIOU(const T* boxes_data, int32_t box_index1, int32_t box_index2) const; | ||
| void MaxMin(const T& lhs, const T& rhs, T& min, T& max) const; | ||
|
|
||
| private : int64_t max_output_size_; |
Contributor
There was a problem hiding this comment.
a new line? #Resolved
| "Integer representing the maximum number of boxes to be selected by non max suppression.", | ||
| AttributeProto::INT) | ||
| .Attr( | ||
| "iou_threshold", |
Contributor
There was a problem hiding this comment.
any default value for it? #Resolved
|
|
||
| if (max_output_size_ <= 0 || boxes_dims[0] == 0) { | ||
| std::vector<int64_t> output_dims(1, 0); | ||
| TensorShape output_shape(output_dims); |
Contributor
There was a problem hiding this comment.
TensorShape can take an initializer list, so this can be output_shape({1, 0}) to save the overhead of a local vector alloc/destroy. Same thing below for {1, num_to_copy}. #Resolved
Contributor
There was a problem hiding this comment.
Well, not exactly what I said above, whatever the transform from what you have to an initializer list. #Resolved
| sorted_scores_with_index.pop(); | ||
|
|
||
| bool selected = true; | ||
| // Check with existing boxes, suppress if exceed the IOU (Intersection Over Union) threadhold |
Contributor
There was a problem hiding this comment.
threadhold->threshold? #Resolved
Contributor
Author
There was a problem hiding this comment.
good catch. 👍 #Resolved
| "score_threshold", | ||
| "Float tensor representing the threshold for deciding when to remove boxes based on score.", | ||
| AttributeProto::FLOAT); | ||
| } |
Contributor
There was a problem hiding this comment.
Do we want to add shape inference here since the shape inference is enabled by default now? #Resolved
Ke Deng (ke1337)
approved these changes
Dec 1, 2018
Tang, Cheng (souptc)
pushed a commit
that referenced
this pull request
Dec 17, 2018
…from execution - Remove construction of MLValue name -> idx mapping from execution frame to inference session since it needs to be done per session only. - Minor change in Executor interface (eliminate one heap allocation). Related work items: #60
trent (tmccrmck)
pushed a commit
to tmccrmck/onnxruntime
that referenced
this pull request
Aug 28, 2019
…data Missing test data from the rename change
Nat Kershaw (MSFT) (natke)
referenced
this pull request
in natke/onnxruntime
Feb 15, 2022
* Address compliance issue and some minor updates * minor update * Add poli exclusion for RESNETLABELMAP.CS
Ashrit Shetty (ashrit-ms)
added a commit
that referenced
this pull request
Jun 4, 2025
This change generates the telemetry hash before initializing the session to ensure that the telemetry hash is generated correctly and consistently without any issues related to accessing invalid memory. The issue is seen in cases where the initializers are cleared after the session is initialized if the tensor was not pre-allocated with some other tensors in a single 'allocate' call or if the context is not to be saved. ORT does this to remove weights from the graph to save memory. Tested with OnnxRuntimeLoad, CppConsoleDesktop, CppOnnxRuntimeConsoleDesktop
Ashrit Shetty (ashrit-ms)
added a commit
that referenced
this pull request
Jun 12, 2025
This change generates the telemetry hash before initializing the session to ensure that the telemetry hash is generated correctly and consistently without any issues related to accessing invalid memory. The issue is seen in cases where the initializers are cleared after the session is initialized if the tensor was not pre-allocated with some other tensors in a single 'allocate' call or if the context is not to be saved. ORT does this to remove weights from the graph to save memory. Tested with OnnxRuntimeLoad, CppConsoleDesktop, CppOnnxRuntimeConsoleDesktop
Mike Hsu (quic-muchhsu)
pushed a commit
to CodeLinaro/onnxruntime
that referenced
this pull request
Feb 27, 2026
* Fix permissions issue with nightly publish job * Add issue_comment trigger so that this can be played around with more via a new PR
Dmitri Smirnov (yuslepukhin)
pushed a commit
that referenced
this pull request
Mar 17, 2026
add throughput optimization support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.